lkml.org 
[lkml]   [2003]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][TRIVIAL] dep_tristate wants 3 arguments (fwd)
Adrian Bunk wrote:
> Hi Marcelo,
>
> the trivial patch by Rik forwarded below still applies against
> 2.4.24-pre1.
>
> Please apply

Let's not and say we did :)


> ----- Forwarded message from Rik van Riel <riel@surriel.com> -----
>
> Date: Mon, 13 Oct 2003 11:10:36 -0400 (EDT)
> From: Rik van Riel <riel@surriel.com>
> To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
> Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>
> Subject: [PATCH][TRIVIAL] dep_tristate wants 3 arguments
>
> The tokenring Config.in has dep_tristate statements with only two
> arguments. Add the obvious third argument.
>
> diff -urNp linux-5110/drivers/net/tokenring/Config.in linux-10010/drivers/net/tokenring/Config.in
> --- linux-5110/drivers/net/tokenring/Config.in
> +++ linux-10010/drivers/net/tokenring/Config.in
> @@ -21,10 +21,10 @@ if [ "$CONFIG_TR" != "n" ]; then
> dep_tristate ' 3Com 3C359 Token Link Velocity XL adapter support' CONFIG_3C359 $CONFIG_TR $CONFIG_PCI
> tristate ' Generic TMS380 Token Ring ISA/PCI adapter support' CONFIG_TMS380TR
> if [ "$CONFIG_TMS380TR" != "n" ]; then
> - dep_tristate ' Generic TMS380 PCI support' CONFIG_TMSPCI $CONFIG_PCI
> - dep_tristate ' Generic TMS380 ISA support' CONFIG_TMSISA $CONFIG_ISA
> - dep_tristate ' Madge Smart 16/4 PCI Mk2 support' CONFIG_ABYSS $CONFIG_PCI
> - dep_tristate ' Madge Smart 16/4 Ringnode MicroChannel' CONFIG_MADGEMC $CONFIG_MCA
> + dep_tristate ' Generic TMS380 PCI support' CONFIG_TMSPCI $CONFIG_PCI $CONFIG_TMS380TR
> + dep_tristate ' Generic TMS380 ISA support' CONFIG_TMSISA $CONFIG_ISA $CONFIG_TMS380TR
> + dep_tristate ' Madge Smart 16/4 PCI Mk2 support' CONFIG_ABYSS $CONFIG_PCI $CONFIG_TMS380TR
> + dep_tristate ' Madge Smart 16/4 Ringnode MicroChannel' CONFIG_MADGEMC $CONFIG_MCA $CONFIG_TMS380TR

I don't see why this patch is needed.

dep_tristate statements with only three arguments (include desc. text)
are just fine. There is no need for additional arguments.

dep_tristate 'blah blah' CONFIG_BLAH dep...

Further, adding CONFIG_TMS380TR dependency is complete nonsense,
considering that the "if [ "$CONFIG_TMS380TR" != "n" ]" check remains.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:59    [W:0.039 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site