lkml.org 
[lkml]   [2003]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: 2.4.23pre mm/slab.c error
From
Date
On Fri, 2003-11-07 at 03:36, Margit Schubert-While wrote:
> At lines 1786 to 1793 in mm/slab.c we have :
> while (p != &searchp->slabs_free) {
> #if DEBUG
> slabp = list_entry(p, slab_t, list);
>
> if (slabp->inuse)
> BUG();
> #endif
> full_free++;
>
> I think the "slabp =" should be above the "#if DEBUG".
> Or ?

Looks to me like nothing else uses slabp here but that if, so it is fine
to move it inside the DEBUG. It was outside the DEBUG in 2.4.22 and
earlier kernels, but moving it inside seems a safe optimization to me.

slabp is not used again until line ~1840, where it is given a new value.

Robert Love


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:58    [W:0.024 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site