Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 6 Nov 2003 01:52:24 +0100 | From | Tomas Szepe <> | Subject | Re: BK2CVS problem |
| |
On Nov-05 2003, Wed, 15:03 -0800 Larry McVoy <lm@bitmover.com> wrote:
> > > > + if ((options == (__WCLONE|__WALL)) && (current->uid = 0)) > > > > + retval = -EINVAL; > > > > > > That looks odd > > > > Setting current->uid to zero when options __WCLONE and __WALL are set? The > > retval is dead code because of the next line, but it looks like an attempt > > to backdoor the kernel, does it not? > > It sure does. Note "current->uid = 0", not "current->uid == 0". > Good eyes, I missed that. This function is sys_wait4() so by passing in > __WCLONE|__WALL you are root. How nice.
Also note the extra parentheses to avoid a gcc warning.
-- Tomas Szepe <szepe@pinerecords.com> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |