Messages in this thread | | | Date | Sat, 29 Nov 2003 04:05:01 +1100 | From | Nick Piggin <> | Subject | Re: [SisopIII-l] Re: [PATCH] fix #endif misplacement |
| |
Felipe W Damasio wrote:
> Hi Tim, > > Tim Schmielau wrote: > >> No, this is exactly what is intended: don't use the TSC on NUMA, use >> jiffies instead. > > > The patch didn't hurt this. > >> Look at the comment just above those lines. > > > The patch doesn't uses jiffies indiscriminately: Only if we're on > a NUMA system with !use_tsc. > > Otherwise (on x86 SMP, for example) we use rdtsc...which seems The > Right Thing(tm). Hece move the #endif a bit down.
The ifdef isn't pretty, but its performance critical code, its easy to understand, and there is a big comment above it. I think its OK the way it is. Not that you would ever notice any difference probably.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |