lkml.org 
[lkml]   [2003]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] make 2.6 megaraid recognize intel vendor id
Hi Christoph, nice rewrite.

Minor comments - which is not not specific for ypur clean-up, but maybe
worth addressing now?

> +#ifdef CONFIG_PROC_FS
> + if (adapter->controller_proc_dir_entry) {
> + remove_proc_entry("stat", adapter->controller_proc_dir_entry);
> + remove_proc_entry("config",
> + adapter->controller_proc_dir_entry);
remove_proc_entry is an empty do {} while, so the ifdef is not needed.

> +#if MEGA_HAVE_ENH_PROC
Looks like a potential CONFIG option?

> +#ifdef CONFIG_PROC_FS
> + remove_proc_entry("megaraid", &proc_root);
> +#endif
ifdef not needed.

Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:58    [W:0.038 / U:2.896 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site