Messages in this thread | | | From | Rusty Russell <> | Subject | Re: lib.a causing modules not to load | Date | Mon, 17 Nov 2003 13:47:34 +1100 |
| |
In message <1068304571.2048.5.camel@mulgrave> you write: > On Sat, 2003-11-08 at 02:51, Christoph Hellwig wrote: > > On Fri, Nov 07, 2003 at 08:34:19PM -0800, Andrew Morton wrote: > > > How about we just link that function into the kernel and be done with it?
> > > We'll waste a few bytes on SMP machines which have neither ext2 nor ext3 > > > linked-in or loaded as modules, but that doesn't sound very important... > > > > > > (We don't have a kernel/random-support-stuff.c, but we have > > > mm/random-support-stuff.c which for some reason is called mm/swap.c, so > > > I put it there). > > > > Well, this solves the problem for this particular case, but not other > > stuff in lib for other situations. > > I agree...there's much more in lib than just percpu_counter_mod.
I think lib.a should be linked as is if !CONFIG_MODULES, and done as a ..o if CONFIG_MODULES. Other alternatives are possible, but make it tricky if someone adds a module later which wants something in lib.a.
Rusty. -- Anyone who quotes me in their sig is an idiot. -- Rusty Russell. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |