lkml.org 
[lkml]   [2003]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Poss. bug in tulip driver since 2.4.7
Prasanna Meda wrote:
> No, you need to bring the for loop outside the loop.
> - Otherwise we need to reset the setup_frame to
> tp->setup_frame after every loop.
> - You do not need to set the setup_frm for every
> mc address, we can set once after the complete
> has_table is ready.
> And also the 2.4 code missed a bit in tx_flags.
>
> We did the following change that makes it identical
> to 2.2 tulip driver, and it worked.
>
> --- Linux/drivers/net/tulip/tulip_core.c Fri Oct 10 20:22:29 2003
> +++ linux/drivers/net/tulip/tulip_core.c Fri Oct 10 20:28:19 2003


Yeah, that looks better... I'll give it a quick test locally, then push
it to Linus.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:58    [W:0.056 / U:1.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site