Messages in this thread | | | Date | Tue, 11 Nov 2003 14:41:31 -0800 | From | "Martin J. Bligh" <> | Subject | Re: 2.6 /proc/interrupts fails on systems with many CPUs |
| |
>> There are basically no valid new uses of it. There's a few valid legacy >> users (I think the file descriptor array), and there are some drivers that >> use it (which is crap, but drivers are drivers), and it's _really_ valid >> only for modules. Nothing else. > > The IPC code is doing ugly things too: > > void* ipc_alloc(int size) > { > void* out; > if(size > PAGE_SIZE) > out = vmalloc(size); > else > out = kmalloc(size, GFP_KERNEL); > return out; > }
That seems particularly .... odd ... as PAGE_SIZE isn't anywhere near the breakpoint. Worst case (and I know I'll get yelled at for this, but I'll get another amusing analogy out of Linus ;-)) we should just call kmalloc and if it fails, then try vmalloc ...
M.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |