Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 10 Nov 2003 18:59:59 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: [PATCH] irda: fix type of struct irda_ias_set.attribute.irda_attrib_string.len |
| |
On Tue, 11 Nov 2003, Arnaldo Carvalho de Melo wrote: > > Ok, ias_opt->attribute.irda_attrib_string.len is __u8, but > IAS_MAX_STRING = 256... so attribute.irda_attrib_string.len has to be at least > __u18, this patch fix this, please see if it is appropriate and if it is so, > apply.
No, please don't. This (a) changes ABI structures that are exported to user space (b) is unnecessary - since the problem is the _warning_, not the test.
Just shut the warning up by either removing the test (replacing it with a comment about why it's unnecessary), or by adding a cast, ie
unsigned int len = ias_opt->attribute.irda_attrib_string.len;
if (len > IAS_MAX_STRING) { ...
in case the code ever expects IAS_MAX_STRING to be shorter (or if the type is ever changed).
Linus
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |