lkml.org 
[lkml]   [2003]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [2.6.0-test9-mm2] Badness in as_put_request at drivers/block/as-iosched.c:1783


Andrew Morton wrote:

>Ramón Rey Vicente <ramon.rey@hispalinux.es> wrote:
>
>>Hi.
>>
>>Trying to scan de ide-scsi devices of my system, I get this
>>
>>arq->state 4
>>Badness in as_put_request at drivers/block/as-iosched.c:1783
>>Call Trace:
>> [<c01dc908>] as_put_request+0x48/0xa0
>> [<c01d47d3>] elv_put_request+0x13/0x20
>> [<c01d69f2>] __blk_put_request+0x52/0xa0
>> [<c01d6a61>] blk_put_request+0x21/0x40
>> [<c01d9d0e>] sg_io+0x2ee/0x440
>> [<c01da5c0>] scsi_cmd_ioctl+0x3c0/0x480
>> [<c0124b49>] update_process_times+0x29/0x40
>> [<c011949c>] schedule+0x31c/0x620
>> [<d093bb65>] cdrom_ioctl+0x25/0xd60 [cdrom]
>> [<c012eb33>] do_clock_nanosleep+0x1b3/0x300
>> [<c0119800>] default_wake_function+0x0/0x20
>> [<c01d86fa>] blkdev_ioctl+0x7a/0x383
>> [<c01584be>] block_ioctl+0x1e/0x40
>> [<c016158f>] sys_ioctl+0xef/0x260
>> [<c0257c57>] syscall_call+0x7/0xb
>>
>
>It looks to me that a simple set_request()/put_request() will always do
>this.
>
>Nick?
>

Yes. I suppose just add a check for PRESCHED there as well. This
actually can happen in ll_rw_blk.c as well and its pretty hard to
change.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:58    [W:0.033 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site