Messages in this thread | | | Date | Sun, 2 Nov 2003 04:34:02 +0000 | From | Matthew Wilcox <> | Subject | Re: [ACPI] [PATCH][RFC] Clean up Kconfig logic for IA64 ACPI |
| |
On Sat, Nov 01, 2003 at 08:05:44PM -0800, Noah J. Misch wrote: > I do not read linux-ia64 regularly, so I did not notice your work. I > apologize for not acknowledging it.
No problem ;-)
> Why not include drivers/Kconfig and scrap the individual subdirectory > includes, as i386 does?
At that time, I hadn't done the work to create drivers/Kconfig ;-) The main problem for ia64 is the simulator stuff. Maybe something like:
if !IA64_HP_SIM source "drivers/Kconfig" endif
if IA64_HP_SIM source "drivers/base/Kconfig" source "drivers/scsi/Kconfig" source "net/Kconfig" source "drivers/block/Kconfig" source "arch/ia64/hp/sim/Kconfig" endif
(I guess Kconfig needs an "else" keyword).
(Also the duplication of drivers/block/Kconfig is no longer necessary).
> Also, it looks like your patch makes ACPI non-mandatory. Is that intentional?
Hmmm... no ;-) I agree the "select" should probably go in -- we seem to be infected with ACPI for the foreseeable future ;-(
I imagine these kinds of patches can go into 2.6.1 -- the freeze should let up a bit by then.
-- "It's not Hollywood. War is real, war is primarily not about defeat or victory, it is about death. I've seen thousands and thousands of dead bodies. Do you think I want to have an academic debate on this subject?" -- Robert Fisk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |