Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 10 Oct 2003 01:55:22 +0100 | From | Dave Jones <> | Subject | Re: [PATCH] Re: linking problem with 2.6.0-test6-bk10 |
| |
On Fri, Oct 10, 2003 at 01:42:24AM +0100, Nuno Monteiro wrote:
> Got 5 minutes to look at this today, here is the proper fix. This allows > to compile for Winchip when CONFIG_MTRR is off. The alternative would be > to pull in asm/mtrr.h and asm/errno.h, but it seems a bit overkill since > we only need mtrr_centaur_report_mcr. > > Booted and working fine here on my small gateway box for the past hour. > Please apply. > > +#ifndef CONFIG_MTRR > +static __inline__ void mtrr_centaur_report_mcr(int mcr, u32 lo, u32 hi) {;} > +#endif > +
As well as looking pretty ugly, I can't convince myself this is safe. I think it's going to be better off making that whole code compile out if MTRRs are disabled. MTRR is a must-have if we want this code to actually work anyway.
Either change the ifdef at the top of centaur.c to #ifdef CONFIG_X86_OOSTORE && CONFIG_MTRR, or futz around it in the Kconfig, by changing the X86_OOSTORE depends line to
depends on (MWINCHIP3D || MWINCHIP2 || MWINCHIPC6) && MTRR
Dave
-- Dave Jones http://www.codemonkey.org.uk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |