lkml.org 
[lkml]   [2003]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] disable_irq()/enable_irq() semantics and ide-probe.c
Manfred Spraul wrote:
> I'd like to use that for nic shutdown for natsemi:
>
> disable_irq();
> shutdown_nic();
> free_irq();
> enable_irq();


Why not just shutdown the NIC inside spin_lock_irqsave or disable_irq,
and then free_irq separately?

If you can't stop the NIC hardware from generating interrupts, that's a
driver bug. And if the driver cannot handle its interrupt handler
between the spin_unlock_irqrestore() and free_irq() (shared irq case),
it's also buggy.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:49    [W:0.377 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site