Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 09 Oct 2003 12:38:16 -0400 | From | Jeff Garzik <> | Subject | Re: [RFC] disable_irq()/enable_irq() semantics and ide-probe.c |
| |
Manfred Spraul wrote: > I'd like to use that for nic shutdown for natsemi: > > disable_irq(); > shutdown_nic(); > free_irq(); > enable_irq();
Why not just shutdown the NIC inside spin_lock_irqsave or disable_irq, and then free_irq separately?
If you can't stop the NIC hardware from generating interrupts, that's a driver bug. And if the driver cannot handle its interrupt handler between the spin_unlock_irqrestore() and free_irq() (shared irq case), it's also buggy.
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |