Messages in this thread | | | Date | Wed, 8 Oct 2003 15:49:34 +0100 (BST) | From | Hugh Dickins <> | Subject | Re: [PATCH] page->flags corruption fix |
| |
On Tue, 7 Oct 2003, Rik van Riel wrote:
> In the "better safe than sorry" category. Thanks go out to > Matt Domsch and Robert Hentosh. A similar fix went into the > 2.6 kernel. Please apply.
Seven atomic ops in a row, isn't that rather inefficient? The 2.6 version clears those PG_flags all together in one non-atomic op - but elsewhere, in prep_new_page.
Is there an actual test case for why 2.4 now needs this change?
If there's something trying to lock random pages, of course it would be needed; or should that something be taking a reference instead?
Hugh
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |