Messages in this thread | | | Date | Wed, 8 Oct 2003 23:35:44 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH] cleanup of compat_ioctl functions |
| |
Hi!
> > Well, in the light of 'strictly bug fixes only', it was probably too > > much search&replace already. I guess I'll have to prepare a new patch > > that just fixes the bugs in the current s390 compat_ioctl code and not > > use fs/compat_ioctl.c in 2.6.0. > > That doesn't make any sense, the fact that fs/compat_ioctl.c isn't > using the proper compat user pointer accessor macros is a bug, > so just fix that. > > It defeats the whole purpose of this compat layer if people still > need to duplicate the code in some cases.
Agreed, your changes are trivial and reviewed extremely easily. That is not going to break anything. Okay, I guess no need to change __u16 into anything... Pavel -- When do you have a heart between your knees? [Johanka's followup: and *two* hearts?] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |