Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 27 Oct 2003 23:47:28 +0100 | From | Andries Brouwer <> | Subject | Re: [PATCH] PS/2 mouse rate setting |
| |
On Mon, Oct 27, 2003 at 07:38:56PM +0100, Andi Kleen wrote: > On Mon, Oct 27, 2003 at 08:32:15AM -0800, Linus Torvalds wrote:
> > I'd suggest we _not_ set the rate by default at all (and let the default > > thing just happen). And only set the rate if the user _asks_ for it with > > your setup thing. Mind sending me that kind of patch? > > Here's the new patch with this change.
> -unsigned int psmouse_rate = 60; > +unsigned int psmouse_rate = 0;
> +__setup("psmouse_rate=", psmouse_rate_setup);
Hmm. I hate this.
Linus, please - don't ask for such things. Our kernel does not need twelve thousand boot parameters.
Mouse rate is of no importance during boot. Ergo, there is no reason to have it a boot parameter.
Doing the default thing is good enough, I agree. And if the user wants something else, userspace should take care.
Andries
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |