Messages in this thread | | | Date | Sun, 19 Oct 2003 20:17:57 +0200 | From | Pavel Machek <> | Subject | Re: [RFC] prevent "dd if=/dev/mem" crash |
| |
Hi!
> > Old behavior: > > > > # dd if=/dev/mem of=/dev/null > > <unrecoverable machine check> > > I recently fixed this for ia32 by changing copy_to_user() to not oops if > the source address generated a fault. Similarly copy_from_user() returns > an error if the destination generates a fault.
Are you sure this is not hiding real errors? If you pass wrong kernel ptr to copy_*_user, it should oops, not mask error with -EFAULT. Maybe another copy_user_unsafe should be created? Pavel -- Pavel Written on sharp zaurus, because my Velo1 broke. If you have Velo you don't need...
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |