lkml.org 
[lkml]   [2003]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] remove unnecessary #includes from <linux/fs.h>
On Thu, 2 October 2003 19:22:19 +0200, Sam Ravnborg wrote:
> On Thu, Oct 02, 2003 at 06:16:39PM +0200, Jörn Engel wrote:
> >
> > You didn't comment on my suggestion, so I've done it manually once for
> > linux/fs.h and was shocked. It still passes my compile-standalone
> > test after removing 11! #include lines.
>
> Be careful here.
> Maybe fs.h passes your compile test, but it may break other users of
> fs.h, that relyed on a certain .h file to be included by fs.h.
> This kind of clean-up belongs to 2.7.

Agreed. Maybe Tim has his check-both-branches approach finished by
then, too.

Jörn

--
Good warriors cause others to come to them and do not go to others.
-- Sun Tzu
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:49    [W:0.056 / U:0.712 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site