Messages in this thread | | | Date | Thu, 2 Oct 2003 19:26:12 +0200 | From | Jörn Engel <> | Subject | Re: [PATCH] remove unnecessary #includes from <linux/fs.h> |
| |
On Thu, 2 October 2003 19:22:19 +0200, Sam Ravnborg wrote: > On Thu, Oct 02, 2003 at 06:16:39PM +0200, Jörn Engel wrote: > > > > You didn't comment on my suggestion, so I've done it manually once for > > linux/fs.h and was shocked. It still passes my compile-standalone > > test after removing 11! #include lines. > > Be careful here. > Maybe fs.h passes your compile test, but it may break other users of > fs.h, that relyed on a certain .h file to be included by fs.h. > This kind of clean-up belongs to 2.7.
Agreed. Maybe Tim has his check-both-branches approach finished by then, too.
Jörn
-- Good warriors cause others to come to them and do not go to others. -- Sun Tzu - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |