Messages in this thread | | | Date | Fri, 17 Oct 2003 02:35:26 -0700 | From | William Lee Irwin III <> | Subject | Re: highmem-zone memory hotremoval test patch |
| |
On Fri, Oct 17, 2003 at 05:28:35PM +0900, IWAMOTO Toshihiro wrote: > diff -dpur linux-2.6.0-test1/fs/proc/kcore.c linux-2.6.0-test1-mh/fs/proc/kcore.c > --- linux-2.6.0-test1/fs/proc/kcore.c Mon Jul 14 12:34:39 2003 > +++ linux-2.6.0-test1-mh/fs/proc/kcore.c Thu Jul 31 16:01:37 2003 > @@ -450,7 +450,7 @@ static ssize_t read_kcore(struct file *f > } > kfree(elf_buf); > } else { > - if (kern_addr_valid(start)) { > + if (1 /*kern_addr_valid(start)*/) { > unsigned long n; > > n = copy_to_user(buffer, (char *)start, tsz);
kern_addr_valid() has been bogus garbage for a while, and smbfs and ncpfs are swiss cheese. IMHO unless some arch gets its act together and acquires a legitimate use for it, pgdat->valid_addr_bitmap and kern_addr_valid() should be removed. And probably d_validate(), too.
-- wli - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |