Messages in this thread | | | Subject | Re: [PATCH] lne390 and Jensen Alphas | From | Marc Zyngier <> | Date | Sun, 12 Oct 2003 13:24:30 +0200 |
| |
Carsten,
+#ifdef CONFIG_ALPHA_JENSEN + /* On the Jensen board EISA cards will see their own address + * space */ +#else
[...]
+#ifndef CONFIG_ALPHA_JENSEN isa_memcpy_toio(shmem, buf, count); +#else + /* The mylex lne390 adapter requires 32bit access (see above) for every + * operation to the shared mem buffer. Since the block buffer is hardly + * aligned to a 32bit boundary isa_memcpy_toio() will use 16bit + * operations to access the buffer ... we must use something else here. */ + + const void *from = buf; + count -= 4; + do { + __raw_writel(*(const u16 *)from | (*(const u16 *)(from+2))<<16, (unsigned long) shmem); + count -= 4; + (unsigned long) shmem += 4; + from += 4; + } while (count >= 0); +#endif +
This doesn't look to me like a proper fix. You should unconditionally use ioremap and memcpy_{from,to}io (not the isa_* version). No need to have a special Jensen case here.
Please look at the way ne3210.c was fixed in 2.6.0-test7.
M. -- Places change, faces change. Life is so very strange. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |