lkml.org 
[lkml]   [2003]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: 2.6.0-test6: a few __init bugs
Date
In article <1064958129.5264.237.camel@dooby.cs.berkeley.edu>,
Robert T. Johnson <rtjohnso@eecs.berkeley.edu> wrote:
| On Tue, 2003-09-30 at 14:25, Greg KH wrote:
| > Hm, good point. Can you think of a better place for this that would
| > have helped you out?
|
| Take two. It might not have prevented me from reporting the potential
| bug, but I would've known you'd thought about it, it might help future
| developers, and it's unlikely to become dangerously wrong. Thanks.
|
| Best,
| Rob
|
| --- drivers/pci/quirks.c.orig Tue Sep 30 14:17:40 2003
| +++ drivers/pci/quirks.c Tue Sep 30 14:39:48 2003
| @@ -750,6 +750,9 @@
|
| /*
| * The main table of quirks.
| + *
| + * Note: any hooks for hotpluggable devices in this table must _NOT_
| + * be declared __init.
| */
|
| static struct pci_fixup pci_fixups[] __devinitdata = {

Good job, that. Clear, and anyone who doesn't immediately see why
probably is at a skill level to just say 'oh' and do what it says.
--
bill davidsen <davidsen@tmr.com>
CTO, TMR Associates, Inc
Doing interesting things with little computers since 1979.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:49    [W:0.064 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site