Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 09 Jan 2003 13:37:48 -0600 | From | Corey Minyard <> | Subject | Re: [PATCH] PATCH: IPMI driver |
| |
Dave Jones wrote:
>On Thu, Jan 09, 2003 at 01:16:29PM -0600, Corey Minyard wrote: > > > >Pull the 2.5 port from openipmi.sourceforge.net saves you doing the port > > >yourself. > > > > > Definately pull the 2.5 port from there, as there are some differences > > between the 2.4 and 2.5 versions. > >I had a quick skim through the patch. >Is the handling of jiffies wraps done correctly ? It doesn't >look like it... > >time_diff = ((jiffies_now - kcs_info->last_timeout_jiffies) > > Dave > I don't understand why that wouldn't work. Those are both unsigned long values. Assuming twos complement, the time difference could be correct, even in a wraparound case (unless a very large number of jiffies has transpired, but that will never be the case here).
Am I missing something here?
-Corey
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |