Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH]: Remove PF_MEMDIE as it is redundant | From | Juan Quintela <> | Date | 09 Jan 2003 01:01:28 +0100 |
| |
>>>>> "robert" == Robert Love <rml@tech9.net> writes:
robert> On Wed, 2003-01-08 at 18:49, Juan Quintela wrote: >> That is a nice theory, and I think that this could be true in the >> past, but in 2.4.2X, PF_MEMDIE only appears in the two places that I >> show, and it is completely redundant, look at the patch, we are just >> |-ing both PF_MEMALLOC and PF_MEMDIE and later we are &-ing against >> the or of the two. Use find & grep yourself if you don't believe me.
robert> I realize this.
robert> The issue is that PF_MEMALLOC can be _cleared_. In that case, if you robert> only set PF_MEMALLOC, that check can be false when we want it true. So robert> we need a flag that is more persistent.
robert> PF_MEMDIE, which is not cleared on various allocation paths in the VM, robert> ensures that the check holds true for all OOM'ed tasks.
robert> I thought the same as you, "hey this thing is worthless let us dump it", robert> and Rik and Andrew told me otherwise.
robert> I am not saying you are wrong, though - I could be very wrong. But my robert> point is not what you say above; it is that the flag is needed because robert> just setting PF_MEMALLOC is insufficient since it can be unset.
I saw the light, thanks for the explanation.
Later, Juan.
-- In theory, practice and theory are the same, but in practice they are different -- Larry McVoy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |