Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 7 Jan 2003 16:18:06 -0800 | From | Mike Anderson <> | Subject | Re: [PATCH] EDD: fix raw_data file and edd_has_edd30(), misc cleanups |
| |
Matt Domsch [Matt_Domsch@Dell.com] wrote: > * use new find_bus() and bus_for_each_dev() to match SCSI devices
.. snip .. > + struct edd_match_data * data = (struct edd_match_data *)d; > + struct edd_info *info = edd_dev_get_info(data->edev); > + struct scsi_device * sd = to_scsi_device(dev); > + > + if (info) { > + if ((sd->channel == info->params.interface_path.pci.channel) && > + (sd->id == info->params.device_path.scsi.id) && > + (sd->lun == info->params.device_path.scsi.lun)) { > + data->sd = sd; > + return 1; > + }
This change assumes that the scsi sysfs bus only contains struct scsi_device's. According to sysfs policy we are suppose to have only one type of struct on this list, but this is not the case currently.
I will work on a patch tonight to remove these extra nodes so that the st, sg, and osst maintainers can review it.
-andmike -- Michael Anderson andmike@us.ibm.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |