Messages in this thread | | | Date | Sun, 5 Jan 2003 13:23:54 +0100 | From | Ingo Oeser <> | Subject | Re: [ACPI] acpi_os_queue_for_execution() |
| |
Hi Andrew,
On Fri, Jan 03, 2003 at 11:00:04AM -0800, Grover, Andrew wrote: > > From: Pavel Machek [mailto:pavel@ucw.cz] > > Acpi seems to create short-lived kernel threads, and I don't quite > > understand why. [...] > > and acpi_thermal_run creates kernel therad that runs > > acpi_thermal_check. Why is not acpi_thermal_check called directly? I > > don't like idea of thread being created every time thermal zone needs > > to be polled... > > Are we allowed to block in a timer callback? One of the things > thermal_check does is call a control method, which in turn can be very > slow, sleep, etc., so I'd guess that's why the code tries to execute > things in its own thread.
No you just have to switch completely to schedule_work() as you do for calls from interrupts. The limitations you mention in osl.c for this function are lifted (look at linux/kernel/workqueue.c) and we have per CPU workqueues now.
So no need for this uglification and less code to maintain for you ;-)
The short lived threads are not necessary anymore. If this thermal check will happen often an extra permanent thread for this, which is kicked by a timer might be more apropriate here.
That thread could be started, once the thermal control is loaded.
Regards
Ingo Oeser -- Science is what we can tell a computer. Art is everything else. --- D.E.Knuth - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |