Messages in this thread | | | Date | Thu, 02 Jan 2003 22:07:29 -0800 | From | David Brownell <> | Subject | Re: [linux-usb-devel] Re: 2.5.54 -- ohci-dbg.c: 358: In function `show_list': `data1' undeclared (first use in this function) |
| |
Greg KH wrote: > On Thu, Jan 02, 2003 at 04:39:57PM -0800, David Brownell wrote: > >>+#if LINUX_VERSION_CODE > KERNEL_VERSION(2,5,32) >>+# define DRIVERFS_DEBUG_FILES >>+#endif > > > No, this is wrong, don't put this dependant on a specific kernel > version that is long gone, that's why I took this portion out.
Actually it originally there to support a backport of that version to the 2.4 kernel, which has periodically worked. That was the downside of that particular patch of yours ... it didn't wrap the dev_* calls as ohci_* calls, so the backport effort went up.
But OK, I'll remove that for now and resend.
- Dave
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |