Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | Date | Thu, 16 Jan 2003 22:03:27 -0800 | From | William Lee Irwin III <> | Subject | Re: i386 pgd_index() doesn't parenthesize its arg |
| |
PAE's pte_none() and pte_pfn() evaluate their arguments twice; analogous fixes have been made to other things; c.f. pgtable.h's long list of one-line inlines with parentheses still around their args.
===== include/asm-i386/pgtable-3level.h 1.8 vs edited ===== --- 1.8/include/asm-i386/pgtable-3level.h Fri Jul 26 06:23:51 2002 +++ edited/include/asm-i386/pgtable-3level.h Thu Jan 16 21:59:08 2003 @@ -89,8 +89,8 @@ } #define pte_page(x) pfn_to_page(pte_pfn(x)) -#define pte_none(x) (!(x).pte_low && !(x).pte_high) -#define pte_pfn(x) (((x).pte_low >> PAGE_SHIFT) | ((x).pte_high << (32 - PAGE_SHIFT))) +static inline int pte_none(pte_t pte) { return !pte.pte_low && !pte.pte_high; } +static inline unsigned long pte_pfn(pte_t pte) { return (pte.pte_low >> PAGE_SHIFT) | (pte.pte_high << (32 - PAGE_SHIFT)); } static inline pte_t pfn_pte(unsigned long page_nr, pgprot_t pgprot) { - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |