Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | From | Paul Mackerras <> | Date | Sat, 18 Jan 2003 09:20:38 +1100 | Subject | Re: [PATCH]: PPP_FILTER outbound only drops with debugging enables |
| |
Dave,
This patch looks obviously correct, please send it on to Linus.
Paul.
Patrick McHardy writes: > Hi. > > Packets in ppp_send_frame catched by pass_filter are only dropped if > debuging is enabled:
[snip]
--- linux-2.4.20/drivers/net/ppp_generic.c.orig 2003-01-17 13:15:32.000000000 +0100 +++ linux-2.4.20/drivers/net/ppp_generic.c 2003-01-17 13:16:23.000000000 +0100 @@ -965,11 +965,10 @@ if (ppp->pass_filter.filter && sk_run_filter(skb, ppp->pass_filter.filter, ppp->pass_filter.len) == 0) { - if (ppp->debug & 1) { + if (ppp->debug & 1) printk(KERN_DEBUG "PPP: outbound frame not passed\n"); - kfree_skb(skb); - return; - } + kfree_skb(skb); + return; } /* if this packet passes the active filter, record the time */ if (!(ppp->active_filter.filter - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |