Messages in this thread | | | Date | Fri, 17 Jan 2003 16:35:22 +0100 | From | Roman Zippel <> | Subject | Re: [PATCH] Proposed module init race fix. |
| |
Hi,
(I take it as a good sign that I'm not in your .procmailrc yet. :-) )
Rusty Russell wrote:
> > > disk->flags |= GENHD_FL_UP; > > > blk_register_region(MKDEV(disk->major, disk->first_minor), disk->minors, > > > NULL, exact_match, exact_lock, disk); > > > > blk_register_region() allocates memory, which can fail? > > Looks like. But the semantics are the same as before, for better or worse. 8(
This means add_disk() can fail and according to your rules it can only be called once. If add_disk() would called a second time, the module would be live and add_disk() were not allowed to fail anymore.
bye, Roman
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |