Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH] fix up RTM_SETLINK handling | From | Roland Dreier <> | Date | 15 Jan 2003 16:22:22 -0800 |
| |
Roland> To call the netdev notifier chain I had to make Roland> netdev_chain not be static. I added the declaration to Roland> <linux/netdevice.h> but I am open to other ways to give Roland> rtnetlink.c access to netdev_chain.
David> Ummm, what is the problem with using David> register_netdevice_notifier()? It is precisely there so David> that netdev_chain need not be exported.
do_setlink() needs to do the opposite of registering a notifier -- it's changing an interface's address, so it needs to call the netdev_chain with NETDEV_CHANGEADDR (just like the handler for SIOCSIFHWADDR does).
If you prefer, I could add a call_netdevice_notifiers() to dev.c and leave netdev_chain static. Just let me know and I'll make a new patch.
Thanks, Roland - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |