Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH] [TRIVIAL] kstrdup | From | Valdis.Kletnieks@vt ... | Date | Mon, 13 Jan 2003 22:53:32 -0500 |
| |
On Mon, 13 Jan 2003 22:38:03 EST, Jeff Garzik said: > On Mon, Jan 13, 2003 at 10:28:14PM -0500, Valdis.Kletnieks@vt.edu wrote: > > Out of curiosity, who's job is it to avoid the race condition between when > > this function takes the strlen() and the other processor makes it a longer > > string before we return from kmalloc() and do the strcpy()? > > The caller's.
That's cool, long as everybody agrees on that - I've already filled my career quota of chasing down bugs due to non-threadsafe use of str*() functions. ;)
All the same, I'd probably feel better if it used strncpy() instead - there'd still be the possibility of copying now-stale data, but at least you'd not be able to walk off the end of the *new* array's allocated space....
/Valdis
[unhandled content-type:application/pgp-signature] | ![\](/images/icornerr.gif) |