Messages in this thread | | | Date | Fri, 10 Jan 2003 03:48:55 -0800 | From | William Lee Irwin III <> | Subject | Re: spin_locks without smp. |
| |
On Fri, Jan 10, 2003 at 12:42:34PM +0100, Maciej Soltysiak wrote: >> while browsing through the network drivers about the etherleak issue i >> found that some drivers have: >> #ifdef CONFIG_SMP >> spin_lock_irqsave(...) >> #endif >> and some just: >> spin_lock_irqsave(...) >> or similar. >> Which version should be practiced? i thought spinlocks are irrelevant >> without SMP so we should use #ifdef to shorten the execution path.
On Fri, Jan 10, 2003 at 03:45:46AM -0800, William Lee Irwin III wrote: > Buggy on preempt. Remove the #ifdef
Actually the only extant example of this is in eexpress.c
Bill - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |