Messages in this thread | | | Date | Sat, 14 Sep 2002 10:53:13 +0200 | From | Andreas Steinmetz <> | Subject | Re: compile warning fix for smb_debug.h |
| |
I'm just wary about the extra blank which is error prone. Otherwise there's no problem.
Urban Widmark wrote: > On Fri, 13 Sep 2002, Andreas Steinmetz wrote: > > >>Hi, >>attached is a fix for gcc 3.2 deprecated usage warnings for __FUNCTION__ >>in smb_debug.h. As gcc 2.95.3 doesn't issue the warning and can't handle >>the new macro there's a macro selection based on the compiler major >>version. Patch is against 2.4.20pre7. > > > Why not just take the version from 2.5? > Or is there a problem with this one too and gcc2.95.3? > > #ifdef SMBFS_PARANOIA > # define PARANOIA(f, a...) printk(KERN_NOTICE "%s: " f, __FUNCTION__ , ## a) > #else > # define PARANOIA(f, a...) do { ; } while(0) > #endif > > etc. > > Note the extra space ... > > /Urban > >
-- Andreas Steinmetz D.O.M. Datenverarbeitung GmbH
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |