lkml.org 
[lkml]   [2002]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] conditionally re-enable per-disk stats, convert to seq_file
On Wed, 7 Aug 2002, Andries Brouwer wrote:

|
| > On Tue, Aug 06, 2002 at 04:08:48PM +0200, Christoph Hellwig wrote:
| > > This patch against 2.4.20-pre1 converts /proc/partitions to the seq_file
| > > interface as in 2.5, makes it report the sard-style extended disk
| > > statistics condititional on CONFIG_BLK_STATS and disables the gathering
| > > of those totally otherwise to not waste memory and processing power.
|
| But why in /proc/partitions ?
| Maybe /proc/partitions can go away eventually with all info available
| under driverfs or so. But for the time being, /proc/partitions is used,
| and some changes are planned to make identification of the devices
| involved easier.
| It is really ugly to stuff a lot of garbage into a file just because
| it happens to exist already. If you want disk statistics, why not
| put it in /proc/diskstatistics?

me too.

I'd like to see the disk stats added, but not in /proc/partitions.

--
~Randy

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:27    [W:0.108 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site