Messages in this thread | | | Subject | Re: [PATCH] low-latency zap_page_range() | From | Robert Love <> | Date | 29 Aug 2002 16:40:02 -0400 |
| |
On Thu, 2002-08-29 at 16:30, Andrew Morton wrote:
> However with your change, we'll only ever put 256 pages into the > mmu_gather_t. Half of that thing's buffer is unused and the > invalidation rate will be doubled during teardown of large > address ranges.
Agreed. Go for it.
Hm, unless, since 507 vs 256 is not the end of the world and latency is already low, we want to just make it always (FREE_PTE_NR*PAGE_SIZE)...
As long as the "cond_resched_lock()" is a preempt only thing, I also agree with making ZAP_BLOCK_SIZE ~0 on !CONFIG_PREEMPT - unless we wanted to unconditionally drop the locks and let preempt just do the right thing and also reduce SMP lock contention in the SMP case.
Robert Love
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |