Messages in this thread | | | Date | Sat, 10 Aug 2002 17:56:43 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [patch 6/12] hold atomic kmaps across generic_file_read |
| |
On Sat, 10 Aug 2002, Andrew Morton wrote: > > If not, I don't think it's worth making this change just for > the highmem read/write thing (calculating `current' at each > spin_lock site...) I just open coded it.
Well, this way it will now do the preempt count twice (once in kmap_atomic, once in th eopen-coded one) if preempt is enabled.
I'd suggest just making k[un]map_atomic() always do the inc/dec_preempt_count. Other ideas?
Linus
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |