Messages in this thread | | | Date | Wed, 31 Jul 2002 11:32:36 +0200 (CEST) | From | Roman Zippel <> | Subject | Re: [BK PATCH] devfs cleanups for 2.5.29 |
| |
Hi,
On Tue, 30 Jul 2002, Richard Gooch wrote:
> > Are you sure it's save in devfs_open() too? > > Yes. RTFS.
I'm trying - without getting headache. In the "devfs=only" case, where is the module count incremented, when a block device is opened?
> > Even if it's save/fixed, it's still code duplication. > > No. I leverage fops_get(), a common function.
Which is also insufficiently protected. Why do you insist on storing the ops pointer in devfs? As long as devfs is an option, that pointer must be managed at two places.
bye, Roman
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |