Messages in this thread | | | From | Alan Cox <> | Subject | Re: [PATCH] 2.5.28: VM strict overcommit | Date | Thu, 25 Jul 2002 04:18:14 -0400 (EDT) |
| |
> if (!vm_enough_memory((maxpos - inode->i_size) >> PAGE_SHIFT)) { > err = -ENOMEM; > goto out_nc; > } > } > > tmpfs supports holes. Looks to me like a small write which creates > a big hole will be severely over-accounted for?
Intentionally. The base tree doesn't support page cache removal AS callbacks so cannot support the ideal behaviour. The other rounding bits for the tmpfs stuff are I think all fixed in 2.4 by Hugh's stuff, but fixing 2.5 tmpfs is an ongoing seperate project.
> vm_enough_memory() looks really slow. I'll bench this a bit.
On the benches I've run I can't see any difference whatever the accounting mode I am using.
> of memory is dirty" is junk. It really wants to know more > information about the dynamic state of the system. So tracking > all those datums on-the-fly would be handy. One day.
We need it three years ago not "one day"
Alan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |