Messages in this thread | | | Date | Thu, 25 Jul 2002 10:25:26 +0200 | From | Marcin Dalecki <> | Subject | Re: [PATCH] drivers/ide/qd65xx: no cli/sti (2.4.19-pre3 & 2.5.28) |
| |
Vojtech Pavlik wrote: > On Thu, Jul 25, 2002 at 01:45:00AM +0200, Samuel Thibault wrote: > >>Hello, >> >>Here are patches for 2.4.19-pre3 & 2.5.28 which free them from using >>cli/sti in qd65xx stuff. > > > Cool. > > >>(also using ide's OUT_BYTE / IN_BYTE btw) > > > In my opinion this doesn't make sense. The qd65xx is a VESA Local Bus > only hardware and is very very unlikely to be used on anything else than > an x86, where these defines are needed. Also, the ports written to are > not a part of the IDE controller region, so the IN_BYTE/OUT_BYTE macros > might not work there if it was ever used on a non-x86 machine. Also, it > makes the code less readable.
Amen. BTW> I think proper fix is to simple *remove* the cli() cti() commands. They don't make much sense in first place.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |