lkml.org 
[lkml]   [2002]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC] BH removal text
    On Sun, Jul 14, 2002 at 10:22:19AM +0530, Dipankar Sarma wrote:
    >> Even if you replace timemr_bh() with a tasklet, you still need
    >> to take the global_bh_lock to ensure that timers don't race with
    >> single-threaded BH processing in drivers. I wrote this patch [included]
    >> to get rid of timer_bh in Ingo's smptimers, but it acquires
    >> global_bh_lock as well as net_bh_lock, the latter to ensure
    >> that some older protocol code that expected serialization of
    >> NET_BH and timers work correctly (see deliver_to_old_ones()).
    >> They need to be cleaned up too.
    >> My patch of course was experimental to see what is needed to
    >> get rid of timer_bh. It needs some cleanup itself ;-)

    On Thu, Jul 18, 2002 at 01:22:38AM -0700, William Lee Irwin III wrote:
    > I'll follow up with the "before" profile next.

    By the way, since it applies with just offsets to 2.5.26 I did my testing
    on it. Here they are:

    c01210c3 15914360 73.4974 .text.lock.timer
    c0120114 1740662 8.03891 mod_timer
    c0196480 533190 2.46243 csum_partial_copy_generic
    c0196650 409733 1.89227 __generic_copy_to_user
    c0112658 271923 1.25582 try_to_wake_up
    c022893c 227856 1.05231 tcp_v4_rcv
    c021ba91 219423 1.01336 .text.lock.tcp
    c0107bb4 216722 1.00089 apic_timer_interrupt
    c02118a4 160277 0.740208 ip_output
    c011330c 123467 0.570208 schedule
    c021727c 121239 0.559919 tcp_sendmsg
    c0200170 121187 0.559679 dev_queue_xmit
    c02021ad 83061 0.383601 .text.lock.dev
    c02119f4 80365 0.37115 ip_queue_xmit
    c0112f74 77876 0.359655 scheduler_tick
    c01fcd98 75855 0.350322 __kfree_skb
    c010fb30 73084 0.337524 smp_apic_timer_interrupt
    c0218688 68854 0.317989 tcp_data_wait
    c0218af4 66201 0.305736 tcp_recvmsg
    c01207f8 64625 0.298458 timer_bh
    c021e448 55844 0.257905 tcp_ack
    c010cd60 52670 0.243246 do_gettimeofday
    c02207b4 51631 0.238448 tcp_rcv_established

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:27    [W:5.881 / U:0.428 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site