lkml.org 
[lkml]   [2002]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Remain Calm: Designated initializer patches for 2.5
Rusty Russell wrote:
> In message <3D366103.8010403@zytor.com> you write:
>
>>As far as I could tell, *ALL* of these changes broke text alignment in
>>columns.
>
>
> True.
>
>
>>It would have been a lot better if they had maintained spacing; I
>>find the new code much more cluttered and hard to read.
>
>
> I thought about this: I agree it doesn't look as neat, but "hard to
> read" for what purpose? It's just as easy to find a particular field
> you're looking for and it's just as easy to find the end of the
> declaration: I couldn't come up with a convincing argument for needing
> to skim-read these declarations, so I didn't complain to the author.
>

Neatness is about making it easy to read code *quickly*. The pattern
recognizer in your brain doesn't work as well on a jumbled mess.

-hpa



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:27    [W:0.038 / U:0.780 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site