lkml.org 
[lkml]   [2002]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Remain Calm: Designated initializer patches for 2.5
    Em Wed, Jul 17, 2002 at 11:28:32PM -0700, David S. Miller escreveu:
    > From: "H. Peter Anvin" <hpa@zytor.com>
    > Date: Wed, 17 Jul 2002 23:32:35 -0700
    >
    > As far as I could tell, *ALL* of these changes broke text alignment in
    > columns. It would have been a lot better if they had maintained
    > spacing; I find the new code much more cluttered and hard to read.
    >
    > I have to admit that I hate the new syntax too. The GCC syntax is
    > so much nicer.

    Well, I also like the non C99 variant that is in gcc as well, but if gcc is
    going to drop that in the future in favour of the C99 standard... But yes,
    not having the spacing is _ugly_, what I'm doing is:

    static struct proto_ops SOCKOPS_WRAPPED(atalk_dgram_ops) = {
    .family = PF_APPLETALK,
    .release = atalk_release,
    .bind = atalk_bind,
    .connect = atalk_connect,
    .socketpair = sock_no_socketpair,
    .accept = sock_no_accept,
    .
    .
    .

    8)

    - Arnaldo
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:22    [W:2.466 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site