Messages in this thread | | | Date | Mon, 3 Jun 2002 21:13:57 +0200 (MET DST) | From | "Thomas 'Dent' Mirlacher" <> | Subject | Re: do_mmap |
| |
pavel,
> > what about the do_mmap/do_mmap_pgoff implementation? > > reurn-type: _unsigned_ long (which should be ok cause we've to return > > an adress if len == 0) > > on error: -ERR_* > > > > and the checks in various places are really strange. - well some > > places check for: > > o != NULL > > o > -1024UL > > o ... > > > > guess this nedds some cleanup. > > While you are at it... fs/binfmt_elf does mmaps but does not check for errors. > And errors actually do happen there :-(
sure, was tripping over that anyways ... since the compiler spits out tons of "conversion without a cast" warnings (seems to be a different way to use grep :)
i just came across one problem: when converting the unsigned longs to void * pointers, everything works fine, beside the "advanced" pointer arithmetic. (like aligning the address to a certain boundary - using address & MASK) ... for that case i need to cast to an unsigned long in any case :( is there another way to do it without explicit casting? should we introduce ptr_addr_t? can we be sure that an unsigned long is capable to hold and address (also in the future) can we be sure about gcc void * pointer arithmetic (like ++ incremets the address by one)
tm
-- in some way i do, and in some way i don't.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |