Messages in this thread | | | Date | Mon, 3 Jun 2002 17:11:46 -0600 (MDT) | From | Thunder from the hill <> | Subject | Re: [PATCH][2.5] Port opl3sa2 changes from 2.4 |
| |
Hi,
On Mon, 3 Jun 2002, Scott Murray wrote: > I think it would be better to wait until Zwane sends something to Alan > and/or Marcelo, as this patch is incorrect on a couple of levels. See my > annotations below:
His patch won't match for 2.5. I just adapted it, even though I've had a typo there.
> > + opl3sa2_state[card].activated = 1; > > This line should really be below the following if statement, as I believe > Zwane mentioned to Gerald.
You could of course have it there. No problem with that.
> I think always blindly remapping the the DMA channels to 0 and 1 is a bad > idea and will likely break things for some people. It would be better if > the core isapnp code could be made smarter, but a simple alternative would > be to rework the opl3sa2 module parameter parsing to allow using the DMA > parameters as an override when using PnP.
As I mentioned, I was just porting it.
> Scott
Regards, Thunder -- ship is leaving right on time | Thunder from the hill at ngforever empty harbour, wave goodbye | evacuation of the isle | free inhabitant not directly caveman's paintings drowning | belonging anywhere
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |