Messages in this thread | | | Date | Fri, 21 Jun 2002 08:59:35 +1000 | From | Rusty Russell <> | Subject | Re: Linux 2.5.23 cpu_online_map undeclared |
| |
On Wed, 19 Jun 2002 05:36:08 +0000 (UTC) torvalds@transmeta.com (Linus Torvalds) wrote:
> Actually, it _should_ be declared, it's just that on UP it should be > defined to the constant 1. > > Somehow that #define got dropped by the hotplug-CPU stuff.
Actually, was deliberate. Not exposing the mask when almost everyone just wants to know "are any of these cpus online" was a preemptive strike against NR_CPUS > BITS_PER_LONG (I wouldn't have bothered but I was so close anyway).
My mistake was not noticing that x86 SMP was still exposing it and that scheduler changes since my original patch were using it. Fixed with cpu_online_mask(res, mask) in prior patch.
Apologies, and hope that clarifies, Rusty. -- there are those who do and those who hang on and you don't see too many doers quoting their contemporaries. -- Larry McVoy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |