lkml.org 
[lkml]   [2002]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] 2.5.21 kill warnings 4/19
Greg KH wrote:
> On Mon, Jun 10, 2002 at 01:26:53PM +0200, Martin Dalecki wrote:
>
>>Fix improper usage of __FUNCTION__ in usb code.
>
>
> It's not improper. Well it wasn't when it was written, but the gcc
> authors decided to change their minds... :(
>
> As stated before, I'll clean up all of the USB drivers later all at
> once, and the pci hotplug drivers as well. The USB drivers could use
> with some good debugging macro cleanup in general...
>
> Martin, any reason you are doing all of this "cleanup" without sending
> the patches to the relevant maintainers?

1. I know you read lkml.

2. The patches are trival.

3. Having them helps using GCC 3.1, which turns out to be a big
winner contrary to 3.0.xx.

4. I use GCC 3.1 becouse I hate having different compilers on the system
and becouse I do some C++ too.

5. We have to do it anyway - so what?

6. In esp. ARM seems to be much better off with GCC 3.1 then anything else.

7. Separating __FUNCTION__ out from string const concatenation allows
the compiler to coalesce the storage used for this string in to one constant!

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:26    [W:0.036 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site