Messages in this thread | | | Date | Wed, 22 May 2002 18:09:38 +0400 | From | Andrey Panin <> | Subject | Re: [PATCH] SLC82C105 IDE driver: missing __init |
| |
On Wed, May 22, 2002 at 02:10:06PM +0100, Alan Cox wrote: > > slc82c105_bridge_revision() functions lacks __init modifier. > > Attached patch (against 2.5.17) fixes it. > > Compiles, but untested. Please consider applying. > > I wouldnt get too carried away with these. Once the IDE core is clean > enough to allow hot plugging of IDE interfaces those __init's are all going > to need changing anyway
Then we'll grep and change them to __devinit. But missing __init can't be changed :))
> (and yes you can get hot pluggable IDE setups already - the mobility stuff > for example has a case with a PCI split bridge, 3 or 4 PCI slots and > connects to the cardbus on a laptop)
-- Andrey Panin | Embedded systems software engineer pazke@orbita1.ru | PGP key: wwwkeys.eu.pgp.net[unhandled content-type:application/pgp-signature] | |