lkml.org 
[lkml]   [2002]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] Fix BUG macro
Date
Hi

On Thursday 16 May 2002 04:08, Rusty Russell wrote:

>--- linux-2.5.15/include/asm-i386/page.h Wed May 15 19:53:25 2002
>+++ working-2.5.15-rcu/include/asm-i386/page.h Thu May 16 17:34:47 2002
>@@ -96,11 +96,16 @@
> */
>
> #if 1 /* Set to zero for a slightly smaller kernel */
>+#define __STRINGIZE2(x) #x
>+#define __STRINGIZE(x) __STRINGIZE2(x)
> #define BUG() \
> __asm__ __volatile__( "ud2\n" \
> "\t.word %c0\n" \
> "\t.long %c1\n" \
>- : : "i" (__LINE__), "i" (__FILE__))
>+ "\t.long %c2\n" \
>+ : : "i" (__LINE__), \
>+ "i" (__STRINGIZE(KBUILD_BASENAME)), \
>+ "i" (__FUNCTION__))
> #else
> #define BUG() __asm__ __volatile__("ud2\n")
> #endif

Minor nit : any reason why you don't use __stringify from
include/linux/stringify.h ?

Ghoz
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:26    [W:0.325 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site