Messages in this thread | | | Date | Sun, 7 Apr 2002 06:16:16 -0400 (EDT) | From | Rob Radez <> | Subject | Re: WatchDog Driver Updates |
| |
On Sun, 7 Apr 2002, Zwane Mwaikambo wrote:
> static int sc1200wdt_release(struct inode *inode, struct file *file) > { > -#ifndef CONFIG_WATCHDOG_NOWAYOUT > if (expect_close) { > sc1200wdt_write_data(WDTO, 0); > printk(KERN_INFO PFX "Watchdog disabled\n"); > @@ -202,7 +197,6 @@ > sc1200wdt_write_data(WDTO, timeout); > printk(KERN_CRIT PFX "Unexpected close!, timeout = %d > min(s)\n", timeout); > } > -#endif > > hmm, that would allow closing of the watchdog even if > CONFIG_WATCHDOG_NOWAYOUT is specified. Was this your intention?
No it doesn't because expect_close will never be set to anything but 0 if CONFIG_WATCHDOG_NOWAYOUT is set. So the if(expect_close) will never be true.
Regards, Rob Radez
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |