lkml.org 
[lkml]   [2002]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [ANNOUNCE] Linux Trace Toolkit 0.9.5
    Hi,

    On Wed, 24 Apr 2002, Karim Yaghmour wrote:

    > As I said earlier, a 2.5.x patch is available and LTT is ready to
    > be integrated into the 2.5 series.

    I'd really like to see it go in, but I think some small problems are left,
    mostly formatting. Please read Documentation/CodingStyle.
    Please use tabs for indentation and not spaces.
    You should consider using more inline functions, instead of lots of "do
    {...} while(0)" macros.
    Do we really need more usages of uint32_t or uint8_t in the kernel?
    Instead of using lots of "#ifdef __arch__" you should move this into
    <asm/trace.h>.
    Comments are nice, but IMO your code does a bit too much of it, e.g.:

    /* Everything is OK */
    return 0;

    or

    /* Unlock the table for reading */
    read_unlock(&custom_list_lock);

    bye, Roman

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:25    [W:3.699 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site